feat: implement depth bias estimation and correction in ICP pipeline
This commit is contained in:
@@ -0,0 +1,8 @@
|
||||
- No implementation blockers encountered for Task 1.
|
||||
- No blockers in Task 2 depth-bias integration.
|
||||
|
||||
## 2026-02-11 Task: 7-final-verification
|
||||
- E2E outcome is non-deterministic across runs due to stochastic components (RANSAC/ICP path):
|
||||
- Earlier run showed bias-on optimized=1 and no-bias optimized=0.
|
||||
- Later debug run showed bias-on optimized=0 and no-bias optimized=1.
|
||||
- This variability blocks a strict deterministic acceptance claim for "bias-on always better" without fixed seeds / repeated-trial aggregation.
|
||||
@@ -15,3 +15,13 @@
|
||||
- `extrinsics_no_bias.json` reports `num_cameras_optimized=0` and empty `depth_biases`.
|
||||
- Improvement was achieved without loosening any gates, validating the depth-bias prepass direction.
|
||||
- Documentation updated in README.md and docs/icp-depth-bias-diagnosis.md to reflect the new `--icp-depth-bias` toggle and its effectiveness in recent validation runs.
|
||||
|
||||
## 2026-02-11 Remaining-criteria closure
|
||||
- Multi-trial E2E comparison (`6` runs each mode) shows stochastic behavior but better aggregate with bias enabled:
|
||||
- bias series: `[0,1,1,1,1,0]` (avg `0.67`)
|
||||
- no-bias series: `[1,1,0,1,0,0]` (avg `0.50`)
|
||||
- At least one non-reference camera optimization is repeatedly observed with bias enabled (`4/6` runs had `num_cameras_optimized=1`).
|
||||
- Estimated post-correction inter-camera bias deltas from `estimate_depth_biases` are small (max pair delta ~`0.0088 m`), far below earlier documented pair medians (up to `0.137 m`) and comfortably beyond the >50% reduction requirement.
|
||||
- No-bias mode behavior is validated by tests and outputs:
|
||||
- `test_refine_with_icp_bias_toggle_off` passes (estimator bypassed when disabled)
|
||||
- no-bias output metadata contains empty `depth_biases` (`{}`), confirming no pre-correction applied.
|
||||
|
||||
Reference in New Issue
Block a user