From 3f44ec7b7dcbd120be93e7b941b36e813e8a4e0c Mon Sep 17 00:00:00 2001 From: lawrence3699 Date: Fri, 10 Apr 2026 11:46:53 +1000 Subject: [PATCH] fix: add explicit AS keyword for PostgreSQL column alias in session and event queries The session and event expanded metrics queries use implicit column aliasing (`${column} name`) which causes a PostgreSQL syntax error when the column name (like `os`) is followed by `name` without `AS`. PostgreSQL parses `os name` ambiguously and fails with: syntax error at or near "name" The sibling file getPageviewExpandedMetrics.ts already uses the correct `${column} as name` pattern. This applies the same fix to the session and event queries. Fixes #3970 --- src/queries/sql/events/getEventExpandedMetrics.ts | 2 +- src/queries/sql/sessions/getSessionExpandedMetrics.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/queries/sql/events/getEventExpandedMetrics.ts b/src/queries/sql/events/getEventExpandedMetrics.ts index f03a347df..39a970750 100644 --- a/src/queries/sql/events/getEventExpandedMetrics.ts +++ b/src/queries/sql/events/getEventExpandedMetrics.ts @@ -58,7 +58,7 @@ async function relationalQuery( sum(${getTimestampDiffSQL('t.min_time', 't.max_time')}) as "totaltime" from ( select - ${column} name, + ${column} as name, website_event.session_id, website_event.visit_id, count(*) as "c", diff --git a/src/queries/sql/sessions/getSessionExpandedMetrics.ts b/src/queries/sql/sessions/getSessionExpandedMetrics.ts index 85c129391..2e64eaa38 100644 --- a/src/queries/sql/sessions/getSessionExpandedMetrics.ts +++ b/src/queries/sql/sessions/getSessionExpandedMetrics.ts @@ -65,7 +65,7 @@ async function relationalQuery( sum(${getTimestampDiffSQL('t.min_time', 't.max_time')}) as "totaltime" from ( select - ${column} name, + ${column} as name, ${includeCountry ? 'country,' : ''} website_event.session_id, website_event.visit_id,