From a8c1f267756ea5f797fc9c96c58dcd7abd99aa2d Mon Sep 17 00:00:00 2001 From: Francis Cao Date: Mon, 4 May 2026 14:26:27 -0700 Subject: [PATCH] remove duration from session property stats --- .../session-data/SessionPropertyChart.tsx | 12 +----------- src/lib/types.ts | 1 - .../sql/sessions/getSessionDataActivityStats.ts | 14 +++++--------- 3 files changed, 6 insertions(+), 21 deletions(-) diff --git a/src/app/(main)/websites/[websiteId]/session-data/SessionPropertyChart.tsx b/src/app/(main)/websites/[websiteId]/session-data/SessionPropertyChart.tsx index 5ae934723..048ac08d7 100644 --- a/src/app/(main)/websites/[websiteId]/session-data/SessionPropertyChart.tsx +++ b/src/app/(main)/websites/[websiteId]/session-data/SessionPropertyChart.tsx @@ -3,7 +3,7 @@ import { DistributionBarChart } from '@/components/charts/DistributionBarChart'; import { Empty } from '@/components/common/Empty'; import { LoadingPanel } from '@/components/common/LoadingPanel'; import { useMessages, useMobile, useSessionDataActivityStatsQuery } from '@/components/hooks'; -import { formatLongNumber, formatShortTime } from '@/lib/format'; +import { formatLongNumber } from '@/lib/format'; import type { PropertyFilter } from '@/lib/types'; import { Column, DataColumn, DataTable, Grid, Row, Text } from '@umami/react-zen'; import { useMemo } from 'react'; @@ -123,16 +123,6 @@ export function SessionPropertyChart({ {row => formatLongNumber(row.events)} - - {row => - formatShortTime(Math.abs(~~Number(row.totaltime)), ['h', 'm', 's'], ' ') - } - diff --git a/src/lib/types.ts b/src/lib/types.ts index f512c50bc..dd365aeab 100644 --- a/src/lib/types.ts +++ b/src/lib/types.ts @@ -96,7 +96,6 @@ export interface PropertyLeaderboardRow { visits: number; views: number; events: number; - totaltime: number; } export interface QueryOptions { diff --git a/src/queries/sql/sessions/getSessionDataActivityStats.ts b/src/queries/sql/sessions/getSessionDataActivityStats.ts index 3da98140b..c8bb0a277 100644 --- a/src/queries/sql/sessions/getSessionDataActivityStats.ts +++ b/src/queries/sql/sessions/getSessionDataActivityStats.ts @@ -22,7 +22,7 @@ async function relationalQuery( propertyFilters: PropertyFilter[] = [], ) { const { timezone = 'utc' } = filters; - const { rawQuery, parseFilters, getPropertyFilterQuery, getTimestampDiffSQL } = prisma; + const { rawQuery, parseFilters, getPropertyFilterQuery } = prisma; const { filterQuery, cohortQuery, joinSessionQuery, queryParams } = parseFilters({ ...filters, websiteId, @@ -65,8 +65,7 @@ async function relationalQuery( count(*) as visits, sum(activity) as activity, sum(views) as views, - sum(events) as events, - sum(${getTimestampDiffSQL('min_time', 'max_time')}) as totaltime + sum(events) as events from session_rollup group by session_id ), @@ -89,8 +88,7 @@ async function relationalQuery( count(distinct property_values.session_id) as sessions, coalesce(sum(session_stats.visits), 0) as visits, coalesce(sum(session_stats.views), 0) as views, - coalesce(sum(session_stats.events), 0) as events, - coalesce(sum(session_stats.totaltime), 0) as totaltime + coalesce(sum(session_stats.events), 0) as events from property_values join session_stats on session_stats.session_id = property_values.session_id group by property_values.value @@ -145,8 +143,7 @@ async function clickhouseQuery( count() as visits, sum(activity) as activity, sum(views) as views, - sum(events) as events, - sum(max_time - min_time) as totaltime + sum(events) as events from session_rollup group by session_id ), @@ -167,8 +164,7 @@ async function clickhouseQuery( uniq(property_values.session_id) as sessions, ifNull(sum(session_stats.visits), 0) as visits, ifNull(sum(session_stats.views), 0) as views, - ifNull(sum(session_stats.events), 0) as events, - ifNull(sum(session_stats.totaltime), 0) as totaltime + ifNull(sum(session_stats.events), 0) as events from property_values join session_stats on session_stats.session_id = property_values.session_id group by property_values.value